Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests on maroto level #342

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Add tests on maroto level #342

merged 3 commits into from
Oct 10, 2023

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Oct 10, 2023 •
edited
Loading

Description

  • Add tests on maroto level

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Attention: 97 lines in your changes are missing coverage. Please review.

Comparison is base (0cecd01) 45.13% compared to head (faef728) 45.48%.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v2     #342      +/-   ##
==========================================
+ Coverage   45.13%   45.48%   +0.35%     
==========================================
  Files          42       49       +7     
  Lines        1538     1645     +107     
==========================================
+ Hits          694      748      +54     
- Misses        828      881      +53     
  Partials       16       16
Flag Coverage Δ
unittests 45.48% <0.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/config/builder.go 58.60% <0.00%> (ø)
maroto.go 9.66% <0.00%> (-0.06%) ⬇️
pkg/props/cell.go 0.00% <0.00%> (ø)
pkg/core/entity/dimensions.go 0.00% <0.00%> (ø)
pkg/core/entity/protection.go 0.00% <0.00%> (ø)
pkg/core/entity/margins.go 0.00% <0.00%> (ø)
pkg/props/font.go 25.00% <0.00%> (-13.88%) ⬇️
pkg/core/entity/image.go 0.00% <0.00%> (ø)
pkg/core/entity/metadata.go 0.00% <0.00%> (ø)
pkg/core/entity/config.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher changed the title Improve tests Add tests on maroto level Oct 10, 2023
@johnfercher johnfercher merged commit bb2e738 into v2 Oct 10, 2023
@johnfercher johnfercher deleted the v2-improve-tests branch October 10, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnfercher